Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: make applayout afternavigation package private #5543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor!: make applayout afternavigation package private #5543

wants to merge 2 commits into from

Conversation

ugur-vaadin
Copy link
Contributor

Description

AppLayout.afterNavigation does not serve the same purpose as AfterNavigationObserver.afterNavigation, therefore causes confusion. It does not need to be public. This PR makes the API package-private.

Marked as breaking since it might have been used in place of AfterNavigationObserver.afterNavigation in some cases.

Fixes #5449

Type of change

  • Bugfix
  • Feature
  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@ugur-vaadin ugur-vaadin marked this pull request as ready for review October 6, 2023 06:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen added the requires new major This would be a breaking change label Feb 28, 2024
@yuriy-fix
Copy link
Contributor

Should be revisited before 25.0. Added to the breaking changes list for 25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

@DiegoCardoso DiegoCardoso Awaiting requested review from DiegoCardoso

Assignees
No one assigned
Labels
requires new major This would be a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppLayout does not provide UI in afterNavigation method
3 participants
@ugur-vaadin @yuriy-fix @vursen